Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Team ratings into Small team and big team #296

Merged
merged 26 commits into from
Jun 9, 2024
Merged

Split Team ratings into Small team and big team #296

merged 26 commits into from
Jun 9, 2024

Conversation

L-e-x-o-n
Copy link
Collaborator

No description provided.

@L-e-x-o-n L-e-x-o-n marked this pull request as draft May 26, 2024 12:09
@L-e-x-o-n L-e-x-o-n self-assigned this May 28, 2024
@L-e-x-o-n
Copy link
Collaborator Author

Update after tests on integration server:

We played a small team game match and it got correctly rated, shown on Teiserver and leaderboards.
$whoami reports correct rating but server side balance didn't create balance until $makebalance was used.
Unfortunately, Chobby and SPADS are still showing the default rating, likely because they are still pointed to server4 in some places.

Considering that next season is happening in 14h, these feature will be delayed until it can be more properly tested to make sure everything works as expected.

@L-e-x-o-n L-e-x-o-n closed this May 28, 2024
@L-e-x-o-n L-e-x-o-n marked this pull request as ready for review June 4, 2024 15:09
@StanczakDominik StanczakDominik marked this pull request as draft June 4, 2024 16:00
@L-e-x-o-n L-e-x-o-n mentioned this pull request Jun 4, 2024
Merged
@L-e-x-o-n L-e-x-o-n marked this pull request as ready for review June 9, 2024 16:25
StanczakDominik
StanczakDominik reviewed Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few optional suggestions and questions and we can do the thing!

lib/teiserver/account/reports/open_skill_report.ex
@@ -69,7 +69,7 @@ defmodule Teiserver.Account.OpenSkillReport do
defp apply_defaults(params) do
Map.merge(
%{
"rating_type" => "Team",
"rating_type" => "Big Team",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make an issue to improve this report and make this a selector but I have a started branch with that anyway

lib/teiserver/battle/libs/match_lib.ex Outdated Show resolved Hide resolved
lib/teiserver/battle/libs/match_lib.ex Outdated Show resolved Hide resolved
lib/teiserver/battle/libs/match_lib.ex Outdated Show resolved Hide resolved
lib/teiserver_web/controllers/report/rating_controller.ex Outdated Show resolved Hide resolved
lib/teiserver_web/live/moderation/report_user/index.ex Show resolved Hide resolved
test/teiserver/account/account_test.exs Outdated Show resolved Hide resolved
lib/teiserver/game/servers/balancer_server.ex Outdated Show resolved Hide resolved
@StanczakDominik StanczakDominik merged commit 9b27c07 into beyond-all-reason:master Jun 9, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanczakDominik StanczakDominik StanczakDominik left review comments

@jauggy jauggy jauggy left review comments

Assignees

@L-e-x-o-n L-e-x-o-n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@L-e-x-o-n @jauggy @StanczakDominik